Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix transparent current playlist view controller nav bar #87

Open
wants to merge 1 commit into
base: hotfix/cover-art-issue-and-ios13-missing-icons
Choose a base branch
from

Conversation

mattneub
Copy link

This PR fixes a bug where the navigation bar above the current playlist was transparent and so was hard to see. (Perhaps the bug only manifests itself when you're building in a current version of Xcode, but no matter.)

How to test

Add something to the queue and start playing it. OK, you can stop playing it now; the point is that you are now on the player screen for that song. Tap the queue icon at the top right. You are now on the screen in question! Previously, the words "Done" and "Play Queue" were hard to see because the nav bar surrounding them was transparent. Now they aren't. This is what it looks like now on my device:

Screenshot 2023-12-18 at 10 47 11

I'm not sure what the intended background color was, but this looks good and harmonizes with the rest of the view in both light and dark mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant